Fix file upload on iOS Safari#19
Merged
Merged
Conversation
jaak0b
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS Safari the picker sheet showed a real visible file input, but tapping it did nothing: the OS file dialog never opened. iOS Safari only treats an element as tappable (and fires its click / default action) when it looks interactive to Safari; a bare styled file input inside the sheet did not qualify, so the tap was silently ignored. Attaching real touch/click event listeners to the input makes Safari treat it as interactive, and the dialog now opens (confirmed on an iPhone running iOS 18).
This keeps those event listeners on the input (they are the fix) and points them at the browser console, and removes the temporary on-screen debug log that was used to diagnose this. Desktop and Android were unaffected throughout.