Rewrite ScanNTune as a Vue web app and retire the C# desktop and WASM app#21
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rite # Conflicts: # src/ScanNTune.Browser/wwwroot/interop.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The C# Avalonia-on-WebAssembly build froze during analysis: wasm there is single-threaded (so the OpenCV work ran on the sole UI thread), interpreted, linked at
-O0, and boxed into a 256 MB heap. True multithreading in the browser needs cross-origin-isolation headers GitHub Pages cannot set. Web is the only target, so the app is rewritten as a plain web app that runs the same measurement pipeline off the main thread.What
web/: Vue 3 + TypeScript + Vite + Vuetify. The CV engine is ported 1:1 to TypeScript and runs in a Web Worker via OpenCV.js, so analysis never blocks the UI, needs no special headers, and is fast. Native HTML file/number inputs replace the whole Avalonia mobile-input workaround saga.TestData_2solid.pngfixture at the same tolerances (23 rings, ~0 skew, isotropy) via Vitest, plus Playwright over real scans (the card recovers ~23.6 px/mm; the two-scan flow completes on 35 MP scans without freezing).src/, the C# workflows, and the C#-only root tooling are deleted. Kept:web/, the coupon model (calibration_coupon.scad/.stl), andimg/.web-ci.ymlbuilds + unit-tests + e2e-tests on PRs and master;deploy-web.ymlpublishesweb/distto GitHub Pages on push to master (served at https://jaak0b.github.io/ScanNTune/). The e2e scan fixtures are stored in Git LFS.Verification
npm run buildclean, 60/60 Vitest pass, 3/3 Playwright e2e pass over the real scans.