fix(database): Fixed concurrency issues in DB queries between containers#583
Merged
Conversation
Replaced the per-request _create_connection() / conn.close() pattern with a module-level singleton _get_connection(). Each Gunicorn worker now opens one connection for its lifetime and pulls the remote replica once at startup, rather than reconnecting on every request. The replica path is now derived inside _get_connection() using getpid() after the worker fork, giving each worker its own file (e.g. urls-25.db ). This eliminates the DatabaseError: File is locked by another process errors that occurred when all 25 workers tried to open the same path simultaneously. Added conn.push() after commit() in insert_link and increment_click. Without this, writes only existed in the local replica and were lost on container restart since /tmp is ephemeral. BREAKING CHANGE: Updating database logic
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the per-request _create_connection() / conn.close() pattern with a module-level singleton _get_connection(). Each Gunicorn worker now opens one connection for its lifetime and pulls the remote replica once at startup, rather than reconnecting on every request. The replica path is now derived inside _get_connection() using getpid() after the worker fork, giving each worker its own file (e.g. urls-25.db
). This eliminates the DatabaseError: File is locked by another process errors that occurred when all 25 workers tried to open the same path simultaneously. Added conn.push() after commit() in insert_link and increment_click. Without this, writes only existed in the local replica and were lost on container restart since /tmp is ephemeral.
BREAKING CHANGE: Updating database logic