Skip to content

Fix unknown server.connected SSE#3

Merged
jacobjmc merged 1 commit intomainfrom
codex/fix-unknown-server-connected-sse
Mar 6, 2026
Merged

Fix unknown server.connected SSE#3
jacobjmc merged 1 commit intomainfrom
codex/fix-unknown-server-connected-sse

Conversation

@jacobjmc
Copy link
Owner

@jacobjmc jacobjmc commented Mar 6, 2026

Summary

  • handle unknown server.connected SSE events in the backend translation layer
  • update related shared/frontend thread handling to keep session state in sync
  • add regression coverage for the reducer path touched by this fix

Notes

  • this PR was created from the local commit that could not be pushed directly to protected main

Summary by cubic

Fixes translation of unknown session/server SSE states so turns complete reliably and errors surface to the UI, and keeps removed threads hidden across syncs. Also improves background helper prompts and lets commit message generation use the selected model.

  • Bug Fixes

    • Translate session.error SSE into a single error event and finish the turn.
    • Emit turn/completed on idle even when no active turn exists.
    • Keep removed threads hidden on future thread syncs (with tests).
    • Use the selected model for commit message generation.
    • Update About page GitHub link.
  • Refactors

    • Replace SSE streaming for background helper prompts with REST polling of messages/status.
    • Parse assistant message parts and surface errors from message info.
    • Support model overrides via providerID/modelID or best-match by name.
    • Add tests for SSE translation and helper message parsing.

Written for commit c3621d0. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src-tauri/src/shared/codex_aux_core.rs">

<violation number="1" location="src-tauri/src/shared/codex_aux_core.rs:429">
P2: `/session/status` can return "active" or "running"; treating only "busy"/"retry" as active causes premature "No response was generated" errors while the session is still processing. Include the other active status values in the reset case.</violation>
</file>

You're on the cubic free plan with 18 free PR reviews remaining this month. Upgrade for unlimited reviews.

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@jacobjmc jacobjmc merged commit 58186f5 into main Mar 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant