Merged
Conversation
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src-tauri/src/shared/codex_core.rs">
<violation number="1" location="src-tauri/src/shared/codex_core.rs:1132">
P2: Add a byte-size limit before/after base64 decode for data URL images. Decoding unbounded payloads can cause high memory usage or OOM under large inline images.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
…ion (#10) * Initial plan * Add pre/post-decode size guards for data URL base64 images Co-authored-by: jacobjmc <111402762+jacobjmc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jacobjmc <111402762+jacobjmc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by cubic
Reduces memory use in thread-heavy sessions by evicting inactive thread caches, virtualizing long message lists, and materializing inline image data URLs to temp files. Keeps the UI responsive and prevents unbounded growth.
@tanstack/react-virtualto cut DOM nodes and improve scroll performance.data:image/*URLs to temp files in the Rust core, deduplicate by hash, and reuse the path to reduce memory and payload size, with 8 MB pre/post-decode guards for base64 images.Written for commit efbbf16. Summary will update on new commits.