A "name" property assigned in the bean constructor#10
Open
raykamp wants to merge 1 commit intojacobrosenthal:masterfrom
raykamp:master
Open
A "name" property assigned in the bean constructor#10raykamp wants to merge 1 commit intojacobrosenthal:masterfrom raykamp:master
raykamp wants to merge 1 commit intojacobrosenthal:masterfrom
raykamp:master
Conversation
Owner
|
No thoughts really. Seems fine. |
Owner
|
Why dont we use a gitter https://gitter.im/jacobrosenthal/ble-bean |
Collaborator
Author
|
Hey @jacobrosenthal, any thoughts on merging this PR in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @jacobrosenthal, @sandeepmistry had originally suggested that we make this change to ble-bean.
It's a more convenient accessor for the Bean's name.
thoughts?