Open
Conversation
Collaborator
|
is there a reason you can't set this within your app? |
Author
|
Looks hard coded in the library and don't see anything about setting it in the docs- is it configurable somehow? |
Collaborator
|
Does updating the class variable not work? If we want to make updating the version more ergonomic, we should add a configuration parameter for that instead of hard coding it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, our organization received a message from Netsuite that we are using one of the unsupported SOAP web services endpoint versions (versions 2017_2 to 2021_1) and we need to upgrade. This PR updates the WSDL version from 2021.1.0 to 2024.2.0. Updating the hardcoded wsdl url makes the tests pass, but let me know if any other testing is needed.