Allow users to flag a time step (x values) as invalid within the derivative function#44
Open
mind-bending-forks wants to merge 5 commits into
Open
Conversation
…ering an invalid timestep
…p cannot be reduced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #43
Maybe something like this could work?
I've introduced a user-callable
flag_invalid()function tork_class. It can be called from within the derivative function, following the waystop()is implemented. This approach doesn't break existingcodeusage of the library. Behaviour should only be changed if the user introduced and calls the newflag_invalid()function. (Existing tests run and pass.)For fixed timestep methods, calling
flag_invalid()will throw an exception, since nothing can be done about it.For variable timestep methods with variable step, it will result in the timestep being halved and the step retried. Existing limits on the smallest stepsize and on the maximum number of retries apply.
I've only added handling of the new private
invalidparameter withrk_classafterstep()has been called.The private
stoppedparameter ofrk_classalso has handling after calls toroot_scalar()andsolver_func(). I don't understand the code sufficiently to know whether handling ofinvalidis needed in those cases too. I have assumed not. If you know otherwise, then this pull request might need some additional work.