Add mutex to defergroup.Group for thread safety#2
Draft
KSH-KOR wants to merge 1 commit intojaeyeom:masterfrom
Draft
Add mutex to defergroup.Group for thread safety#2KSH-KOR wants to merge 1 commit intojaeyeom:masterfrom
KSH-KOR wants to merge 1 commit intojaeyeom:masterfrom
Conversation
Protect Defer, Done, CancelAll, and Transfer with sync.Mutex so Group can be used safely from multiple goroutines. Done snapshots and clears the function list under the lock, then runs callbacks unlocked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
@jaeyeom Cloud you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Testing
go test -race ./defergroup/...— passes with no race conditions detectedbazel test //defergroup:go_default_test— passesVersion Compatibility
Demo
Ops Impact