refactor: align test structure to src/ and fix framework API breakage#174
Merged
refactor: align test structure to src/ and fix framework API breakage#174
Conversation
Test structure changes: - Rename test files to match source module names (e.g. aamf-output-schema → agent-output-schemas) - Remove 'coverage-gaps' and legacy naming from test files - Move flow step tests into tests/flow/steps/ mirroring src/flow/steps/ - Move KB/lore tests from tests/core/ to tests/lore/ - Delete obsolete claude-runner.test.ts (tested removed wrapper) Source fixes for @cadre-dev/framework API changes: - shared.ts: remove broken classifyError import from framework/runtime - cost-estimator.ts: pass pricing via costOverrides (models key removed) - cost-estimator.ts: implement 80/20 split in estimateFromTotal directly - token-tracker.ts: replace framework delegation with standalone tracking (loadFromAggregates and getByWorkItem removed from framework) - retry.ts: implement retry loop natively (computeDelay and RETRY_ORIGINAL removed from framework); preserves fast infr removed from framework); preserves fast infr removed from framework); preserves fast infr removed from framework); ptes removed from framewo (all pre-existing)
…untime - agent-launcher.ts: map to issueNumber (workItemId removed from framework) - runtime.ts: remove signal/hooks from FlowRunnerOptions (no longer supported), process phase results from executionOutputs post-run instead - Resolves all 17 pre-existing type errors from framework consolidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns test file naming/structure to mirror
src/and fixes all 17 pre-existing type errors + 31 test failures from the@cadre-dev/frameworkconsolidation in #173.Test structure changes
tests/agents/aamf-output-schema,claude-agent-definitions,result-parseragent-output-schemas,generator,plan-parsertests/core/claude-runner,progress-writer,infra-error-detectionprogress(others moved/deleted)tests/flow/coverage-gaps,shared-steps*,step-phase-*,flow-dslerror-classification,migration-flow,steps/subdirectorytests/lore/kb-search-handler,kb-search-tool,kb-server(moved fromtests/core/)Source fixes for
@cadre-dev/frameworkAPI changessrc/flow/steps/shared.tsclassifyErrorremoved fromframework/runtimesrc/budget/cost-estimator.tsmodelsconfig key removedcostOverrides; implement 80/20 split directlysrc/budget/token-tracker.tsloadFromAggregates/getByWorkItemremovedsrc/execution/retry.tscomputeDelay/RETRY_ORIGINALremovedsrc/core/agent-launcher.tsworkItemIdremoved from frameworkAgentInvocationissueNumbersrc/core/runtime.tssignal/hooksremoved fromFlowRunnerOptionsexecutionOutputspost-runResults
tsc --noEmit)