fix: remove phantom phase 2 gap and renumber phases contiguously (0-8)#178
Merged
fix: remove phantom phase 2 gap and renumber phases contiguously (0-8)#178
Conversation
Eliminate the gap left when the impact-assessor agent was removed. Old: 0, 1, [undefined], 3, 4, 5, 6, 7, 8, 9 New: 0, 1, 2, 3, 4, 5, 6, 7, 8 Renumbering (old → new): Phase 3 (KB Construction) → Phase 2 Phase 4 (Migration Strategy) → Phase 3 Phase 5 (Iterative Migration) → Phase 4 Phase 6 (Final Parity) → Phase 5 Phase 7 (E2E Testing & Docs) → Phase 6 Phase 8 (Idiomatic Refactor) → Phase 7 Phase 9 (Completion) → Phase 8 Changes across 50 files: - Flow definition (migration-flow.ts): remove undefined slot from PHASE_BOUNDARY_NODE_IDS, update nodeIdToPhase map, fix --phase CLI range (0-8), update budget-gate node IDs. - Flow steps: update phase literals, comments, log messages, and local variable names in all 10 step files. - Checkpoint: rename PhaseCursorMap keys (5→4, 6→5, 7→6, 8→7), rename cursor interfaces (Phase5Curs rename cursor interfaces (Phase5Curs rename cursor interfaces (Phase5Curs rename cursor interfaces (Phase5Curs rename cursor interfaces rra rename cursor interfaces (Phase5Curs rename cursor interfaces ili rename cursor interfaces (Phase5Curs renc rename cursor inte. - Docs: up- Docs: up- Docs: up- Doccu- Docs: up- Docs: up- Docs: up- Doccu-, docs/configuration.md, and agent templates. - Tests: update 25 test files with new phas- Tests: update 25 test file and test descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate the phantom phase 2 gap left when the
impact-assessoragent was removed. Phases are now contiguous 0→1→2→3→4→5→6→7→8.Renumbering
2Impact AssessmentWhat changed (50 files)
migration-flow.ts): removedundefinedslot fromPHASE_BOUNDARY_NODE_IDS(nowreadonly string[]), updatednodeIdToPhasemap, fixed--phaseCLI range (0-8), updated budget-gate node IDs.PhaseCursorMapkeys ('5'→'4','6'→'5','7'→'6','8'→'7'), renamed cursor interfaces (Phase5Cursor→Phase4Cursor, etc.), renamed cursor helper functions (getPhase5TaskState→getPhase4TaskState, etc.).phasesarrays for all 14 agent entries.claude.md,README.md,docs/configuration.md, and agent templates.Verification
tsc --noEmitpasses cleanlore/tree-sitternative module failures unchanged)