fix(benchmark): always use current build MCP server, add benchmark skill#210
Merged
fix(benchmark): always use current build MCP server, add benchmark skill#210
Conversation
…skill (#210) The lore-enabled benchmark arm was silently getting a dead MCP server because findLoreProjectRoot() checked the cloned repo first. For lore-self benchmarks the clone is at a pinned SHA (660be2b) that predates the realpathSync entry-guard fix (ee708f8), so the old server.js fails the /var vs /private/var check on macOS and main() never runs. Changes: - findLoreProjectRoot() now resolves exclusively from import.meta.dirname (the current checkout), never from the cloned target repo. Throws if dist/server/server.js is missing instead of silently falling through. - Remove redundant --deny-tool for control arm — the MCP isn't registered so lore_* tools simply don't exist. - Remove token count estimator — use actual outputTokens from copilot NDJSON stream only. - Add copilot-benchmark skill (.github/skills/copilot-benchmark/SKILL.md).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 80 80
Lines 9048 9048
Branches 2798 2798
=======================================
Hits 7966 7966
Misses 1082 1082 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jafreck
added a commit
that referenced
this pull request
Mar 15, 2026
…for C/C++ (#211) * fix(benchmark): always use current build's MCP server, add benchmark skill (#210) The lore-enabled benchmark arm was silently getting a dead MCP server because findLoreProjectRoot() checked the cloned repo first. For lore-self benchmarks the clone is at a pinned SHA (660be2b) that predates the realpathSync entry-guard fix (ee708f8), so the old server.js fails the /var vs /private/var check on macOS and main() never runs. Changes: - findLoreProjectRoot() now resolves exclusively from import.meta.dirname (the current checkout), never from the cloned target repo. Throws if dist/server/server.js is missing instead of silently falling through. - Remove redundant --deny-tool for control arm — the MCP isn't registered so lore_* tools simply don't exist. - Remove token count estimator — use actual outputTokens from copilot NDJSON stream only. - Add copilot-benchmark skill (.github/skills/copilot-benchmark/SKILL.md). * feat(scip): auto-install indexers and generate compile_commands.json for C/C++ * fix(ci): exclude installer and compdb from coverage thresholds * test(scip): add unit tests for installer and compdb with injectable IO mocks * test(scip): raise installer coverage to 86%, restore statements threshold to 85%
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
findLoreProjectRoot()to always resolve the MCP server from the current checkout, not from a pinned-SHA clone that may lack therealpathSyncentry-guard fix.Changes:
findLoreProjectRoot()resolves fromimport.meta.dirnameonly; throws ifdist/server/server.jsis missing--deny-toolfor control arm (MCP isn't registered, tools don't exist)outputTokensfrom copilot NDJSON directlycopilot-benchmarkskill