updated requirements, fixed line endings of assemblies.manifest.new#7
Open
jpstotz wants to merge 1 commit intojakev:masterfrom
Open
updated requirements, fixed line endings of assemblies.manifest.new#7jpstotz wants to merge 1 commit intojakev:masterfrom
jpstotz wants to merge 1 commit intojakev:masterfrom
Conversation
Owner
|
Hi Jan - Thanks for the pull request! I'll look into this and merge it if it all works! :) |
Owner
|
Actually quick question - I assume you're unpacking the APK using |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the original version of pyxamstore created line endings
\r\r\n(0x0D 0x0D 0x0A) which looked strange and most likely will not be accepted by Xamarin (not tested).The Xamarin app I was checking had only 0x0A in its
assemblies.manifestso I would assume always just using\nis the best solution.