Remove change event on old element when re-initializing selectify #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call el.off("change") if .data("sl") is true.
I have two selects on my page, and need to change the available option in the second select based on what's chosen in the first select. After an option is chosen on the first select, I call .selectify() on the second select to update its list of items.
This alteration ensures that we don't hook up two "change" events to the same element if selectify() is called multiple times on the same <select>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call el.off("change") if .data("sl") is true.
I have two selects on my page, and need to change the available option in the second select based on what's chosen in the first select. After an option is chosen on the first select, I call .selectify() on the second select to update its list of items.
This alteration ensures that we don't hook up two "change" events to the same element if selectify() is called multiple times on the same .