-
Notifications
You must be signed in to change notification settings - Fork 0
ios and android apps via Capacitor #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| # Using Android gitignore template: https://github.com/github/gitignore/blob/HEAD/Android.gitignore | ||
|
|
||
| # Built application files | ||
| *.apk | ||
| *.aar | ||
| *.ap_ | ||
| *.aab | ||
|
|
||
| # Files for the ART/Dalvik VM | ||
| *.dex | ||
|
|
||
| # Java class files | ||
| *.class | ||
|
|
||
| # Generated files | ||
| bin/ | ||
| gen/ | ||
| out/ | ||
| # Uncomment the following line in case you need and you don't have the release build type files in your app | ||
| # release/ | ||
|
|
||
| # Gradle files | ||
| .gradle/ | ||
| build/ | ||
|
|
||
| # Local configuration file (sdk path, etc) | ||
| local.properties | ||
|
|
||
| # Proguard folder generated by Eclipse | ||
| proguard/ | ||
|
|
||
| # Log Files | ||
| *.log | ||
|
|
||
| # Android Studio Navigation editor temp files | ||
| .navigation/ | ||
|
|
||
| # Android Studio captures folder | ||
| captures/ | ||
|
|
||
| # IntelliJ | ||
| *.iml | ||
| .idea/workspace.xml | ||
| .idea/tasks.xml | ||
| .idea/gradle.xml | ||
| .idea/assetWizardSettings.xml | ||
| .idea/dictionaries | ||
| .idea/libraries | ||
| # Android Studio 3 in .gitignore file. | ||
| .idea/caches | ||
| .idea/modules.xml | ||
| # Comment next line if keeping position of elements in Navigation Editor is relevant for you | ||
| .idea/navEditor.xml | ||
|
|
||
| # Keystore files | ||
| # Uncomment the following lines if you do not want to check your keystore files in. | ||
| #*.jks | ||
| #*.keystore | ||
|
|
||
| # External native build folder generated in Android Studio 2.2 and later | ||
| .externalNativeBuild | ||
| .cxx/ | ||
|
|
||
| # Google Services (e.g. APIs or Firebase) | ||
| # google-services.json | ||
|
|
||
| # Freeline | ||
| freeline.py | ||
| freeline/ | ||
| freeline_project_description.json | ||
|
|
||
| # fastlane | ||
| fastlane/report.xml | ||
| fastlane/Preview.html | ||
| fastlane/screenshots | ||
| fastlane/test_output | ||
| fastlane/readme.md | ||
|
|
||
| # Version control | ||
| vcs.xml | ||
|
|
||
| # lint | ||
| lint/intermediates/ | ||
| lint/generated/ | ||
| lint/outputs/ | ||
| lint/tmp/ | ||
| # lint/reports/ | ||
|
|
||
| # Android Profiling | ||
| *.hprof | ||
|
|
||
| # Cordova plugins for Capacitor | ||
| capacitor-cordova-android-plugins | ||
|
|
||
| # Copied web assets | ||
| app/src/main/assets/public | ||
|
|
||
| # Generated Config files | ||
| app/src/main/assets/capacitor.config.json | ||
| app/src/main/assets/capacitor.plugins.json | ||
| app/src/main/res/xml/config.xml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /build/* | ||
| !/build/.npmkeep |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,54 @@ | ||||||||||||||||||||||||||||||
| apply plugin: 'com.android.application' | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| android { | ||||||||||||||||||||||||||||||
| namespace = "dev.pages.hnfeed" | ||||||||||||||||||||||||||||||
| compileSdk = rootProject.ext.compileSdkVersion | ||||||||||||||||||||||||||||||
| defaultConfig { | ||||||||||||||||||||||||||||||
| applicationId "dev.pages.hnfeed" | ||||||||||||||||||||||||||||||
| minSdkVersion rootProject.ext.minSdkVersion | ||||||||||||||||||||||||||||||
| targetSdkVersion rootProject.ext.targetSdkVersion | ||||||||||||||||||||||||||||||
| versionCode 1 | ||||||||||||||||||||||||||||||
| versionName "1.0" | ||||||||||||||||||||||||||||||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | ||||||||||||||||||||||||||||||
| aaptOptions { | ||||||||||||||||||||||||||||||
| // Files and dirs to omit from the packaged assets dir, modified to accommodate modern web apps. | ||||||||||||||||||||||||||||||
| // Default: https://android.googlesource.com/platform/frameworks/base/+/282e181b58cf72b6ca770dc7ca5f91f135444502/tools/aapt/AaptAssets.cpp#61 | ||||||||||||||||||||||||||||||
| ignoreAssetsPattern = '!.svn:!.git:!.ds_store:!*.scc:.*:!CVS:!thumbs.db:!picasa.ini:!*~' | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| buildTypes { | ||||||||||||||||||||||||||||||
| release { | ||||||||||||||||||||||||||||||
| minifyEnabled false | ||||||||||||||||||||||||||||||
| proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
Comment on lines
+19
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Consider enabling code minification for release builds. With If you intentionally want to keep it disabled for debugging purposes initially, consider adding a TODO comment to enable it before production release. 🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| repositories { | ||||||||||||||||||||||||||||||
| flatDir{ | ||||||||||||||||||||||||||||||
| dirs '../capacitor-cordova-android-plugins/src/main/libs', 'libs' | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| dependencies { | ||||||||||||||||||||||||||||||
| implementation fileTree(include: ['*.jar'], dir: 'libs') | ||||||||||||||||||||||||||||||
| implementation "androidx.appcompat:appcompat:$androidxAppCompatVersion" | ||||||||||||||||||||||||||||||
| implementation "androidx.coordinatorlayout:coordinatorlayout:$androidxCoordinatorLayoutVersion" | ||||||||||||||||||||||||||||||
| implementation "androidx.core:core-splashscreen:$coreSplashScreenVersion" | ||||||||||||||||||||||||||||||
| implementation project(':capacitor-android') | ||||||||||||||||||||||||||||||
| testImplementation "junit:junit:$junitVersion" | ||||||||||||||||||||||||||||||
| androidTestImplementation "androidx.test.ext:junit:$androidxJunitVersion" | ||||||||||||||||||||||||||||||
| androidTestImplementation "androidx.test.espresso:espresso-core:$androidxEspressoCoreVersion" | ||||||||||||||||||||||||||||||
| implementation project(':capacitor-cordova-android-plugins') | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| apply from: 'capacitor.build.gradle' | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| try { | ||||||||||||||||||||||||||||||
| def servicesJSON = file('google-services.json') | ||||||||||||||||||||||||||||||
| if (servicesJSON.text) { | ||||||||||||||||||||||||||||||
| apply plugin: 'com.google.gms.google-services' | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| } catch(Exception e) { | ||||||||||||||||||||||||||||||
| logger.info("google-services.json not found, google-services plugin not applied. Push Notifications won't work") | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
Comment on lines
+47
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion | 🟠 Major Improve google-services.json existence check. Using ♻️ Proposed fix-try {
- def servicesJSON = file('google-services.json')
- if (servicesJSON.text) {
- apply plugin: 'com.google.gms.google-services'
- }
-} catch(Exception e) {
- logger.info("google-services.json not found, google-services plugin not applied. Push Notifications won't work")
-}
+def servicesJSON = file('google-services.json')
+if (servicesJSON.exists()) {
+ apply plugin: 'com.google.gms.google-services'
+} else {
+ logger.info("google-services.json not found, google-services plugin not applied. Push Notifications won't work")
+}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // DO NOT EDIT THIS FILE! IT IS GENERATED EACH TIME "capacitor update" IS RUN | ||
|
|
||
| android { | ||
| compileOptions { | ||
| sourceCompatibility JavaVersion.VERSION_21 | ||
| targetCompatibility JavaVersion.VERSION_21 | ||
| } | ||
| } | ||
|
|
||
| apply from: "../capacitor-cordova-android-plugins/cordova.variables.gradle" | ||
| dependencies { | ||
|
|
||
|
|
||
| } | ||
|
|
||
|
|
||
| if (hasProperty('postBuildExtras')) { | ||
| postBuildExtras() | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Add project specific ProGuard rules here. | ||
| # You can control the set of applied configuration files using the | ||
| # proguardFiles setting in build.gradle. | ||
| # | ||
| # For more details, see | ||
| # http://developer.android.com/guide/developing/tools/proguard.html | ||
|
|
||
| # If your project uses WebView with JS, uncomment the following | ||
| # and specify the fully qualified class name to the JavaScript interface | ||
| # class: | ||
| #-keepclassmembers class fqcn.of.javascript.interface.for.webview { | ||
| # public *; | ||
| #} | ||
|
|
||
| # Uncomment this to preserve the line number information for | ||
| # debugging stack traces. | ||
| #-keepattributes SourceFile,LineNumberTable | ||
|
|
||
| # If you keep the line number information, uncomment this to | ||
| # hide the original source file name. | ||
| #-renamesourcefileattribute SourceFile |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,26 @@ | ||||||||||||||||||||||||||||||
| package com.getcapacitor.myapp; | ||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Package name mismatch with the application. The test file is placed in package Consider moving this file to 🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| import static org.junit.Assert.*; | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| import android.content.Context; | ||||||||||||||||||||||||||||||
| import androidx.test.ext.junit.runners.AndroidJUnit4; | ||||||||||||||||||||||||||||||
| import androidx.test.platform.app.InstrumentationRegistry; | ||||||||||||||||||||||||||||||
| import org.junit.Test; | ||||||||||||||||||||||||||||||
| import org.junit.runner.RunWith; | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| /** | ||||||||||||||||||||||||||||||
| * Instrumented test, which will execute on an Android device. | ||||||||||||||||||||||||||||||
| * | ||||||||||||||||||||||||||||||
| * @see <a href="http://d.android.com/tools/testing">Testing documentation</a> | ||||||||||||||||||||||||||||||
| */ | ||||||||||||||||||||||||||||||
| @RunWith(AndroidJUnit4.class) | ||||||||||||||||||||||||||||||
| public class ExampleInstrumentedTest { | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| @Test | ||||||||||||||||||||||||||||||
| public void useAppContext() throws Exception { | ||||||||||||||||||||||||||||||
| // Context of the app under test. | ||||||||||||||||||||||||||||||
| Context appContext = InstrumentationRegistry.getInstrumentation().getTargetContext(); | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| assertEquals("com.getcapacitor.app", appContext.getPackageName()); | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
Comment on lines
+19
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test assertion will fail due to incorrect expected package name. The test expects 🔧 Proposed fix `@Test`
public void useAppContext() throws Exception {
// Context of the app under test.
Context appContext = InstrumentationRegistry.getInstrumentation().getTargetContext();
- assertEquals("com.getcapacitor.app", appContext.getPackageName());
+ assertEquals("dev.pages.hnfeed", appContext.getPackageName());
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | ||
|
|
||
| <application | ||
| android:allowBackup="true" | ||
| android:icon="@mipmap/ic_launcher" | ||
| android:label="@string/app_name" | ||
| android:roundIcon="@mipmap/ic_launcher_round" | ||
| android:supportsRtl="true" | ||
| android:theme="@style/AppTheme"> | ||
|
Comment on lines
+4
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Consider the implications of With 🤖 Prompt for AI Agents |
||
|
|
||
| <activity | ||
| android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|smallestScreenSize|screenLayout|uiMode|navigation|density" | ||
| android:name=".MainActivity" | ||
| android:label="@string/title_activity_main" | ||
| android:theme="@style/AppTheme.NoActionBarLaunch" | ||
| android:launchMode="singleTask" | ||
| android:exported="true"> | ||
|
|
||
| <intent-filter> | ||
| <action android:name="android.intent.action.MAIN" /> | ||
| <category android:name="android.intent.category.LAUNCHER" /> | ||
| </intent-filter> | ||
|
|
||
| </activity> | ||
|
|
||
| <provider | ||
| android:name="androidx.core.content.FileProvider" | ||
| android:authorities="${applicationId}.fileprovider" | ||
| android:exported="false" | ||
| android:grantUriPermissions="true"> | ||
| <meta-data | ||
| android:name="android.support.FILE_PROVIDER_PATHS" | ||
| android:resource="@xml/file_paths"></meta-data> | ||
| </provider> | ||
| </application> | ||
|
|
||
| <!-- Permissions --> | ||
|
|
||
| <uses-permission android:name="android.permission.INTERNET" /> | ||
| </manifest> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package dev.pages.hnfeed; | ||
|
|
||
| import com.getcapacitor.BridgeActivity; | ||
|
|
||
| public class MainActivity extends BridgeActivity {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:aapt="http://schemas.android.com/aapt" | ||
| android:width="108dp" | ||
| android:height="108dp" | ||
| android:viewportHeight="108" | ||
| android:viewportWidth="108"> | ||
| <path | ||
| android:fillType="evenOdd" | ||
| android:pathData="M32,64C32,64 38.39,52.99 44.13,50.95C51.37,48.37 70.14,49.57 70.14,49.57L108.26,87.69L108,109.01L75.97,107.97L32,64Z" | ||
| android:strokeColor="#00000000" | ||
| android:strokeWidth="1"> | ||
| <aapt:attr name="android:fillColor"> | ||
| <gradient | ||
| android:endX="78.5885" | ||
| android:endY="90.9159" | ||
| android:startX="48.7653" | ||
| android:startY="61.0927" | ||
| android:type="linear"> | ||
| <item | ||
| android:color="#44000000" | ||
| android:offset="0.0" /> | ||
| <item | ||
| android:color="#00000000" | ||
| android:offset="1.0" /> | ||
| </gradient> | ||
| </aapt:attr> | ||
| </path> | ||
| <path | ||
| android:fillColor="#FFFFFF" | ||
| android:fillType="nonZero" | ||
| android:pathData="M66.94,46.02L66.94,46.02C72.44,50.07 76,56.61 76,64L32,64C32,56.61 35.56,50.11 40.98,46.06L36.18,41.19C35.45,40.45 35.45,39.3 36.18,38.56C36.91,37.81 38.05,37.81 38.78,38.56L44.25,44.05C47.18,42.57 50.48,41.71 54,41.71C57.48,41.71 60.78,42.57 63.68,44.05L69.11,38.56C69.84,37.81 70.98,37.81 71.71,38.56C72.44,39.3 72.44,40.45 71.71,41.19L66.94,46.02ZM62.94,56.92C64.08,56.92 65,56.01 65,54.88C65,53.76 64.08,52.85 62.94,52.85C61.8,52.85 60.88,53.76 60.88,54.88C60.88,56.01 61.8,56.92 62.94,56.92ZM45.06,56.92C46.2,56.92 47.13,56.01 47.13,54.88C47.13,53.76 46.2,52.85 45.06,52.85C43.92,52.85 43,53.76 43,54.88C43,56.01 43.92,56.92 45.06,56.92Z" | ||
| android:strokeColor="#00000000" | ||
| android:strokeWidth="1" /> | ||
| </vector> | ||
|
Comment on lines
+1
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Consider customising the launcher icon. This appears to be the default Android Studio launcher foreground drawable (the Android robot icon). For a production app, you should replace this with custom branding that represents the HN Feed app. 🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix minor wording and capitalisation in the overview.
These are small doc quality issues but user‑facing.
✍️ Suggested wording tweaks
🧰 Tools
🪛 LanguageTool
[misspelling] ~3-~3: This word is normally spelled with a hyphen.
Context: ... This project creates a more intuitive, user friendly UI for Hacker News, with the goal of in...
(EN_COMPOUNDS_USER_FRIENDLY)
[grammar] ~7-~7: A hyphen is missing in the adjective “built-in”.
Context: ...ndalone front-end web-application, with built in PWA compatibility, as well as android a...
(BUILT_IN_HYPHEN)
🤖 Prompt for AI Agents