Conversation
…ybe_uninit_ref feature.
…es. Not required when using pointer-casting to get underlying slice when creating grants.
Owner
|
Apologies for letting this get stale, but I think that the new interface in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I took a stab at #41 here. What's missing is a
bbqueue::heap::FramedProducerandbbqueue::heap::FramedConsumer. Also I'm unsure of how you want to structure the crate in terms of heap vs globally-allocated/stack-allocated.For heap-allocated framed producer/consumer, here's what I'm thinking:
framed::FramedProducerandframed::FramedConsumerintocommon, make them usecommon::Producer/common::Consumerinstead ofbbqueue::Producer/bbqueue::Consumer.bbqueue::FramedProducer/bbqueue::FramedConsumerwith lifetimes re-added.heap::FramedProducer/heap::FramedConsumerwith reference counter for dropping (duplicateheap::Producer/heap::Consumerdropping code.If you like that plan I can go ahead an implement it.
I split the common code into a separate
commonmodule that hasProducer<N>andConsumer<N>types without lifetimes. Thebbbuffermodule exports wrappedProducer<'a, N>andConsumer<'a, N>types with the lifetimes. Theheapmodule exports wrappedProducer<N>andConsumer<N>types that include a reference counter to determine if the underlyingConstBBBuffershould be dropped when the producer/consumer is dropped.