Use abstract critical sections for thumbv6#98
Closed
Sizurka wants to merge 2 commits intojamesmunns:mainfrom
Closed
Use abstract critical sections for thumbv6#98Sizurka wants to merge 2 commits intojamesmunns:mainfrom
Sizurka wants to merge 2 commits intojamesmunns:mainfrom
Conversation
Instead of implementing critical sections directly, use the critical_section crate for abstraction. A simple implementation that disables interrupts is available in cortex-m with a feature switch that preserves existing behavior.
Closed
ithinuel
reviewed
Nov 26, 2023
Collaborator
ithinuel
left a comment
There was a problem hiding this comment.
The change seems good to me. This change makes it portable to any target.
@jamesmunns is it ok to do breaking change before next release?
If so, I think the thumbv6 feature could be removed in favor of the default critical-section feature introduced by the optional flag since it is no longer thumbv6m specific.
Owner
|
@ithinuel please feel free to make any breaking changes! I'm open to either using the |
Collaborator
|
Migration to |
Collaborator
|
Closing in favor of #103. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the critical sections required for thumbv6 to use the abstraction provided by the
critical_sectioncrate. The context here is the RP2040 micocontroller, which is a two core Cortex-M0+ device, so just disabling interrupts on the current core is not sufficient when a bbqueue is used to communicate between cores. However, the HAL provides an implementation of a critical section hooking into the abstraction above to handle this kind of case.With this change, using bbqueue on single core thumbv6 target (equivalent to the current behavior) looks like:
Or for a RP2040 in multi-core mode: