feat: bump a bunch of dependencies#17
Closed
FauxFaux wants to merge 2 commits intojarlef:mainfrom
Closed
Conversation
Owner
|
Thanks for the PR. I have updated the dependencies in another PR since this was already stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the core dependencies seem to work fine after their major version bumps:
jsdomhas mostly added functionality and broken weird modes, and dropped support for old nodedel-clihas dropped support for old nodeI didn't even read the changelog for vite or vitest as I find they're quite good at providing deprecation advice, and there was none printed in any of the steps.
The tests still pass.
biomewants to reformat some files before this change (tabs vs. spaces disagreement), so I left that alone. The new build integrates fine and works in my project.My aim was to remove
(node:658527) [DEP0169] DeprecationWarning:url.parse()behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued forurl.parse()vulnerabilities.from my build, thinking it was injsdom. It's not, it's actually in the code. Oh well, there's always next time.