Draft
Conversation
Owner
|
I think the idea was that the old branch should be deleted after it's merged. In case of a clash, if the versions do not match, I would prefer if the older branch is deleted in favor of the newer branch. e.g. If we've gotten to the step where the versions are compared, if the versions don't match, we should delete the older one. Maybe there should be a check to ensure that the version is actually < the newer version. I don't like the idea of the action creating a whole bunch of new branches that never get cleaned out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for any branch that matches prefix means that if this action ran in the past and a PR was closed, the next time WordPress is upgraded, it happily does nothing. Past PRs are closed in favor of the new one. PRs for the same version are a no-op success.
#18 was created from an old version of the project, trying again. Addresses #16.