[SET-659] add check on Issue/Ticket state if PR is up#100
Open
baranowb wants to merge 1 commit into
Open
Conversation
soul2zimate
reviewed
Apr 2, 2024
soul2zimate
left a comment
soul2zimate
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the proposal and implementation.
LGTM in general, except some small suggestions apply to both new evaluators.
|
|
||
| } | ||
|
|
||
| protected void processPresenceLabel(final Attribute<IssueData> issueKey, final Attribute<LabelData> labelsKey, |
Contributor
There was a problem hiding this comment.
The first three parameters seems unnecessary for this method, you can just use the actual value inside this method. The last parameter context also useless in this method.
|
|
||
| @Override | ||
| public boolean support(ProcessorPhase processorPhase) { | ||
| if (processorPhase == ProcessorPhase.OPEN) { |
Contributor
There was a problem hiding this comment.
can be simplified to return processorPhase == ProcessorPhase.OPEN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/SET-659