fix(exporter): anchor slack webhook regex to prevent false-positive masking#16
Merged
Merged
Conversation
- add ^ and $ anchors to slack webhook URL pattern so it only
matches when the entire value is a webhook URL
- prevent false-positive masking when a webhook URL appears
embedded inside a larger unrelated string
- add table-driven test covering exact match and embedded cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Slack webhook URL regex pattern in
defaultValuePatternsused\bword boundaries, which caused it to match webhook URLs embedded inside larger strings. This led to false-positive masking of values that merely contained a webhook URL as a substring (e.g., a redirect URL wrapping a webhook URL).Solution
Replace the
\bword boundaries with^and$anchors so the pattern only matches when the entire value is a Slack webhook URL.Testing
Added a table-driven test (
TestIsSecretValueSlackWebhook) covering: