Pull Request: Fix Blade Container Binding and blade.compiler Resolution for Illuminate\View v10,v11+#85
Pull Request: Fix Blade Container Binding and blade.compiler Resolution for Illuminate\View v10,v11+#85rcalicdan wants to merge 5 commits into
Conversation
Support illuminate/view 11.0 above and fix blade.compiler does not exist. Support php 8.4
…ally 10 and above. Update README.md to include BladeContainer in instantiation example
…onventions; add pint.json configuration.
|
I have successfully resolved the issues related to the blade.compiler error that occurs in certain versions of the illuminate/view package, specifically versions 10, 11, and 12. Additionally, I have fixed the Blade Container instance to ensure proper functionality. These changes ensure compatibility and stability across the mentioned versions, addressing potential errors and improving the overall reliability of the codebase. The fixes are now ready to be merged. |
emorales-ajpf
left a comment
There was a problem hiding this comment.
Hi! I was checking out the changes needed to adapt to newer versions of upstream, and I noticed a couple things I quite don't understand how they fit in this PR. Thanks!
| .phpunit.cache/ | ||
| .phpunit.result.cache No newline at end of file | ||
| .phpunit.result.cache | ||
| .qodo |
There was a problem hiding this comment.
What's the purpose of .qodo here?
There was a problem hiding this comment.
That's just a folder where my qodo ai extension automatically generate in my project so i put it in gitignore file.
There was a problem hiding this comment.
I think that just Laravel pint auto-formated a php file.
|
Any update on this? |
Summary
This pull request addresses two key issues to ensure compatibility with Illuminate\View v11 and above, and improve the reliability of the Jessenger Blade integration:
Fixes improper container binding for Jessenger Blade
The Blade compiler instance was not being properly resolved from the container, leading to inconsistencies or runtime errors in some contexts.
Fixes missing blade.compiler binding in Illuminate\View v11+
Since Laravel 11 removed or refactored the blade.compiler binding, this fix resolves the compiler using BladeCompiler::class directly for versions v11 and above.
Updated the README
Clarified setup instructions and added notes on Laravel 11+ compatibility to guide developers during installation and configuration.
Changes Made
Testing