Skip to content

fix: doNotSuggest for property and value completion#22

Closed
p-spacek wants to merge 1 commit intojigxfrom
fix/doNotSuggest-for-property-and-value-completion
Closed

fix: doNotSuggest for property and value completion#22
p-spacek wants to merge 1 commit intojigxfrom
fix/doNotSuggest-for-property-and-value-completion

Conversation

@p-spacek
Copy link
Copy Markdown
Collaborator

@p-spacek p-spacek commented Nov 6, 2023

What does this PR do?

RedHat PR: redhat-developer#911

exclude doNotSuggest schema from autocompletion
doNotSuggest was already there but implemented only for the simple object properties.
This PR uses doNotSuggest also for other scenarios: anyOf, values

"anyOf":[
  {
     "$ref": "schema1",
     "doNotSuggest": true
   },
  {
     "$ref": "schema2",
   }
]

Is it tested? How?

adds unit tests

@p-spacek p-spacek closed this Nov 6, 2023
@p-spacek
Copy link
Copy Markdown
Collaborator Author

p-spacek commented Nov 6, 2023

closed because of this PR #23
I need a different branch than the one that is used for Redhat PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant