Fix generated paths to be relative to the workspace.#33
Merged
Jarod42 merged 1 commit intojimon:masterfrom Sep 30, 2024
Merged
Conversation
Collaborator
|
Waiting for premake/premake-core#2244 |
Jarod42
reviewed
Sep 18, 2024
|
|
||
| local getrelative = toolset.getrelative | ||
| if getrelative ~= nil then | ||
| toolset.getrelative = function(cfg, value) |
Collaborator
There was a problem hiding this comment.
clang delegates to gcc (and so gcc.getrelative), so changing clang.getrelative won't work.
I meant that clang.getincludedirs(xx) -> gcc.getincludedirs(xx) -> --[[..]]gcc.getrelative(cfg, path)--[[..]]
I don't even think that p.overrides solve that issue :/
Collaborator
|
premake/premake-core#2244 is merged, that PR need to be updated to take into account the changes. |
tritao
force-pushed
the
fix-relative-paths
branch
2 times, most recently
from
b10f2ed to
3dc48ce
Compare
tritao
force-pushed
the
fix-relative-paths
branch
from
3dc48ce to
e1ba0f7
Compare
Contributor
Author
|
Updated the PR to work with merged upstream API. |
Jarod42
approved these changes
Sep 28, 2024
Collaborator
|
CI failed :-/ Embed scripts broken by premake/premake-core#2264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs a Premake change to work, for which there will be a PR upstream, but should also be safe to merge since it checks if it exists before patching it.