Skip to content

feat(p2p-16): add labeled read-source telemetry (#671)#2

Open
jlon wants to merge 1 commit into
p2p-15-runtime-service-hardeningfrom
p2p-16-metrics-label-telemetry
Open

feat(p2p-16): add labeled read-source telemetry (#671)#2
jlon wants to merge 1 commit into
p2p-15-runtime-service-hardeningfrom
p2p-16-metrics-label-telemetry

Conversation

@jlon
Copy link
Copy Markdown
Owner

@jlon jlon commented Mar 26, 2026

Summary

  • Add labeled observability for read-source attribution, fallback reasons, and P2P metrics.
  • Keep protocol and product-path behavior unchanged; this PR is telemetry-only.

Design

  • Extract tenant and job labels at the read boundary and keep label policy setup centralized.
  • Isolate telemetry plumbing from filesystem API churn and unrelated cleanup.

Implementation

  • Add labeled metrics in client_metrics and thread read-source and fallback telemetry through block_reader.
  • Wire tenant/job label extraction and snapshot sync through fs_reader_base and fs_context.

Verification

  • Run labeled read-source and fallback metrics tests.
  • Run one cached-read regression test plus cargo test -p curvine-client --lib --no-run.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@jlon jlon force-pushed the p2p-15-runtime-service-hardening branch from 2e37480 to e7259f3 Compare March 26, 2026 10:27
@jlon jlon force-pushed the p2p-16-metrics-label-telemetry branch from 2df762f to 6f6817b Compare March 26, 2026 10:27
@jlon jlon force-pushed the p2p-15-runtime-service-hardening branch from e7259f3 to b78378b Compare March 27, 2026 09:33
@jlon jlon force-pushed the p2p-16-metrics-label-telemetry branch from 6f6817b to 1e8c57c Compare March 27, 2026 09:33
@jlon jlon force-pushed the p2p-15-runtime-service-hardening branch from b78378b to e13782e Compare March 30, 2026 00:55
@jlon jlon force-pushed the p2p-16-metrics-label-telemetry branch from 1e8c57c to 057d563 Compare March 30, 2026 00:55
@jlon jlon force-pushed the p2p-16-metrics-label-telemetry branch from 057d563 to 84fbb07 Compare March 31, 2026 03:32
@jlon jlon force-pushed the p2p-15-runtime-service-hardening branch from e13782e to 2a955da Compare March 31, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant