Fix order of arguments for onContentBeforeSave event#173
Fix order of arguments for onContentBeforeSave event#173parapente merged 4 commits intojmcameron:masterfrom
Conversation
|
Seems good to me https://manual.joomla.org/docs/5.4/building-extensions/plugins/plugin-events/content/#oncontentbeforesave |
Hmmm... Maybe I should not add null as the $data argument and use $model as its value. Unfortunately I don't have any plugin that will use this event and the $data argument. This event was added to achieve indexing of the attachments. The finder plugin uses only the first two arguments of the event. I will update the PR later this day. |
…es and just before saving the values to the database
|
For some reason moving the event triggering breaks attachments on newly created articles. This PR is not ready for merge yet. |
|
This should work just fine now. Please test |
|
I propose to merge |
Fixes #171