Skip to content

Some fixes after #174 and #175 PR#180

Merged
JLTRY merged 3 commits intojmcameron:masterfrom
yild:master
Jan 6, 2026
Merged

Some fixes after #174 and #175 PR#180
JLTRY merged 3 commits intojmcameron:masterfrom
yild:master

Conversation

@yild
Copy link
Copy Markdown
Contributor

@yild yild commented Jan 5, 2026

Some fixes after #174 and #175 PR. Removed definitions for deleted cs…s files.

Copy link
Copy Markdown
Collaborator

@JLTRY JLTRY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should use the standard folder structure inside xml definitions
like here <folder>css>/folder>

@yild
Copy link
Copy Markdown
Contributor Author

yild commented Jan 5, 2026

Agreed. Make it so!* :)

*JLP Star Trek

use folders instead of files
@JLTRY
Copy link
Copy Markdown
Collaborator

JLTRY commented Jan 6, 2026

Done so !
@yild can you please review? I checked to install component on a clean website and it works

@parapente
Copy link
Copy Markdown
Collaborator

Looks good @JLTRY . I did some small changes to the file. You can merge the PR

@JLTRY JLTRY merged commit 8ff38d5 into jmcameron:master Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants