Conversation
- Added aggregateQualityAnalysis field to ShotHistoryUiState - Implemented loadAggregateQualityAnalysis() method to calculate quality metrics - Integrated aggregate quality analysis into loadAnalysisData() workflow - Updated memory cleanup to include aggregateQualityAnalysis - Added comprehensive unit tests for aggregate quality analysis: * loadAggregateQualityAnalysis_withShots_updatesState * loadAggregateQualityAnalysis_noShots_setsNull * loadAnalysisData_includesAggregateQuality * toggleAnalysisView_preservesAggregateQuality * applyFilter_refreshesAggregateQuality_whenAnalysisShown - All existing tests pass, no regressions introduced - Lint checks pass Depends on: GetShotQualityAnalysisUseCase (Phase 1) Ready for: Phase 3 - Visual UI Components
- Created QualityScoreGaugeCard with gauge and distribution - Created EnhancedShotTrendsCard with graph and expandable details - Created EnhancedExtractionQualityCard with zone indicator - Created EnhancedBrewRatioCard with visual range indicator - All cards follow design system (CoffeeCard, spacing, typography) - Empty states implemented for insufficient data - Added preview composables for all cards
- Extracted preview sample data values to constants - Extracted Canvas calculation factors to constants - Extracted trend indicator thresholds and colors to constants - All detekt MagicNumber violations resolved
- Move score and tier labels from below gauge to centered overlay position - Reduce spacing between gauge and distribution text from medium to small - Eliminate wasted vertical space while maintaining readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist