Skip to content

Add docker#31

Open
johadi wants to merge 2 commits into
developfrom
add-docker
Open

Add docker#31
johadi wants to merge 2 commits into
developfrom
add-docker

Conversation

@johadi
Copy link
Copy Markdown
Owner

@johadi johadi commented Sep 28, 2019

add docker

['id', 'username', 'email', 'mobile', 'fullname']
);
req.user = userDetails;
req.user = lodash.pick(user, ['id', 'username', 'email', 'mobile', 'fullname', 'avatarPath']);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 8 spaces but found 10 indent

Comment thread server/helpers/helpers.js

export {
sendSMS, sendMail, handleError, handleSuccess, uploadPictureLocally, uploadPictureToCloudinary, updateUserDetails
};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace object-curly-newline

Comment thread server/helpers/helpers.js
}

export {
sendSMS, sendMail, handleError, handleSuccess, uploadPictureLocally, uploadPictureToCloudinary, updateUserDetails
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 215 exceeds the maximum line length of 100 max-len

Comment thread server/helpers/helpers.js
});
}

export {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

Comment thread server/helpers/helpers.js

return handleError(err, res);
});
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

Comment thread server/helpers/helpers.js

return user.update(fieldsInLowercase);
})
.then((updatedUser) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style

Comment thread server/helpers/helpers.js
models.User.findOne({where: {username: req.user.username}})
.then(user => {
if (!user) {
return Promise.reject('Something went wrong');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected the Promise rejection reason to be an Error prefer-promise-reject-errors

Comment thread server/helpers/helpers.js
*/
const updateUserDetails = (req, res, fields) => {
models.User.findOne({where: {username: req.user.username}})
.then(user => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected parentheses around arrow function argument having a body with curly braces arrow-parens

Comment thread server/helpers/helpers.js
* @return {void}
*/
const updateUserDetails = (req, res, fields) => {
models.User.findOne({where: {username: req.user.username}})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

Comment thread server/helpers/helpers.js
height: 200
});
})
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon semi

@johadi johadi force-pushed the develop branch 2 times, most recently from 2fda31c to f8cb6c4 Compare October 14, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants