You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've just noted that line 40 of script/PSLogonFailures.ps1 already declares a variable called $blocklist which the renamed file path variable (on line 31) will collide with. Suggest changing the file path variables to be called $allowListFile and $blockListFile.
I've just noted that line 40 of script/PSLogonFailures.ps1 already declares a variable called $blocklist which the renamed file path variable (on line 31) will collide with. Suggest changing the file path variables to be called $allowListFile and $blockListFile.
Are you able to update your commit please?
Well sorry I didn't see that. Should be fixed now.
Nothing to apologise for @hsteinmueller, I should have noticed when I opened the issue. That's looking good. I'll need to test it but I can probably merge this.
Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1