Optional printing of data value in popover#2
Open
flxReinoud wants to merge 3 commits intojondavidjohn:masterfrom
Open
Optional printing of data value in popover#2flxReinoud wants to merge 3 commits intojondavidjohn:masterfrom
flxReinoud wants to merge 3 commits intojondavidjohn:masterfrom
Conversation
…iguration key in popoverOpts
Owner
|
Thanks for this. Seems like an interesting approach and certainly fits your needs, but I think it's not quite generic enough a solution. I'd like to see this solved with a var chart = new BubbleChart({
canvasId: "bubblechart",
metric: "Kb",
usedArea: 0.35,
contain: true,
popoverOpts: {
textFont: "Open Sans",
detailTemplate: "{data} {metric}" // <------------- Default
},
data : myCustomData()
});That way it would solve your case (by providing just "{metric}") but it would also solve many other custom implementations. For example if someone is doing work with percentages and they want the metric first. |
Owner
|
Also, make sure all pull requests are targeted at the (should probably update CONTRIBUTING.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data value of a bubble was always printed in the popover. We needed to disable the printing of the data in the popover because the absolute values were not relevant for a few of our graphs. This was caused by the absolute values be approximations. This pull request introduces a key in the popoverOpts configuration dict with the name popoverShowData which can be set to false to disable the printing of data in the popover.