Main entry set for package #3#4
Open
rafaelpivato wants to merge 1 commit intojondavidjohn:masterfrom
rafaelpivato:rp_package_main
Open
Main entry set for package #3#4rafaelpivato wants to merge 1 commit intojondavidjohn:masterfrom rafaelpivato:rp_package_main
rafaelpivato wants to merge 1 commit intojondavidjohn:masterfrom
rafaelpivato:rp_package_main
Conversation
Owner
|
As mentioned in #3, we probably want some work to be done to prevent it from attaching globally, if a module system (AMD/CommonJS) is in use. Returning only the |
Owner
|
😞 probably should handle the methods in Been awhile since I looked at this code 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds main entry point for
bubblechartso it can be imported using requirejs or something similar.Warning: My tests did not pass locally, apparently because of changes in QUnit or PhantomJS. As last TravisCI build happened 1 year ago, going through a new build could impose some new issues and require more fixes.