Add menu bar backdrop and screen corner settings#960
Draft
Sebeb wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rough draft PR for the menu bar backdrop and screen corner work. The code is still rough in places and there are known visual limitations called out below, but this gets the current feature work into a reviewable branch.
What changed
None,Tint, andBackdropoptions.Backend / technical notes
MenuBarAppearanceKindso color treatment is separate from solid-vs-gradient tint selection.MenuBarAppearanceConfigurationV2with screen shape defaults and per-display overrides keyed by stable display UUIDs.appearanceKindmodel.Known limitations
Validation
git diff --checkxcodebuild -project Ice.xcodeproj -scheme Ice -configuration Debug CODE_SIGNING_ALLOWED=NO buildSwiftLint was not run locally because
swiftlintis not installed in this environment; the Xcode build completed with the project’s standard SwiftLint warning.Downloadable build
A fork build is available here: https://github.com/Sebeb/Ice/releases/tag/menu-bar-backdrop-screen-corners-draft
Direct zip: https://github.com/Sebeb/Ice/releases/download/menu-bar-backdrop-screen-corners-draft/Ice-menu-bar-backdrop-screen-corners-draft.zip
This build is ad-hoc signed and not notarized, so macOS may require manual approval in Privacy & Security before opening it.