Skip to content

update to flutter 3.7. followed @huseyinhamad #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkoznov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update to flutter 3.7. followed @huseyinhamad #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f626eab
update to flutter 3.7. followed @huseyinhamad
bkoznov Feb 2, 2023
b47b443
version number bump
bkoznov Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions lib/src/chips_input.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ class ChipsInputState<T> extends State<ChipsInput<T>> implements TextInputClient
Future.delayed(const Duration(milliseconds: 300), () {
WidgetsBinding.instance.addPostFrameCallback((_) async {
final renderBox = context.findRenderObject() as RenderBox;
await Scrollable.of(context)?.position.ensureVisible(renderBox).then((_) {
await Scrollable.of(context).position.ensureVisible(renderBox).then((_) {
WidgetsBinding.instance.addPostFrameCallback((_) {
_suggestionsBoxController.overlayEntry?.markNeedsBuild();
});
Expand Down Expand Up @@ -374,6 +374,17 @@ class ChipsInputState<T> extends State<ChipsInput<T>> implements TextInputClient
//TODO
}

@override
void performSelector(String selectorName) {
//TODO
}

@override
void didChangeInputControl(
TextInputControl? oldControl, TextInputControl? newControl) {
//TODO
}

@override
void didUpdateWidget(covariant ChipsInput<T> oldWidget) {
super.didUpdateWidget(oldWidget);
Expand Down Expand Up @@ -419,7 +430,7 @@ class ChipsInputState<T> extends State<ChipsInput<T>> implements TextInputClient
_value.normalCharactersText,
maxLines: 1,
overflow: widget.textOverflow,
style: widget.textStyle ?? theme.textTheme.subtitle1?.copyWith(height: 1.5),
style: widget.textStyle ?? theme.textTheme.titleMedium?.copyWith(height: 1.5),
),
),
Flexible(
Expand Down
2 changes: 1 addition & 1 deletion lib/src/suggestions_box_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class SuggestionsBoxController {
void open() {
if (_isOpened) return;
assert(overlayEntry != null);
Overlay.of(context)?.insert(overlayEntry!);
Overlay.of(context).insert(overlayEntry!);
_isOpened = true;
}

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flutter_chips_input
description: Flutter library for building input fields with InputChips as input options.
version: 1.10.0
version: 1.11.0
homepage: https://github.com/danvick/flutter_chips_input

environment:
Expand Down