Implements fetcher runner by Cron instead of Config.MinFetchInterval#29
Open
moisespsena wants to merge 6 commits into
Open
Implements fetcher runner by Cron instead of Config.MinFetchInterval#29moisespsena wants to merge 6 commits into
moisespsena wants to merge 6 commits into
Conversation
Owner
|
Thanks for the PR, however I intentionally left out the fetch interval from the main config, and left it to each fetcher to implement their own simple logic. For example the S3 fetcher, defaults to 5 minutes whereas the file fetcher defaults to 1 second, if the setting were in the main config (in the form of a duration or a cron schedule) then sane defaults would not be possible. I should probably make this clearer in the docs. Maybe a cron helper might be useful: It would not need to return an error as this the user would not be writing cron strings, but rather it be hard-coded, or it be a selection of 4 interval options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using default cron instance
Using your cron instance