Skip to content

Release: Bump version in package-lock.json as well during the release #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgol wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −7
Open

Release: Bump version in package-lock.json as well during the release #603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e0a335
Release: Bump version in `package-lock.json` as well during the release
mgol Sep 23, 2025
d880355
fixup! Release: Bump version in `package-lock.json` as well during th…
mgol Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions build/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,7 @@ function tagReleaseVersion( next ) {
function updateVersions( next ) {
updateSourceVersion( releaseVersion );
updateReadmeVersion( releaseVersion );
updatePackageVersion( releaseVersion );
next();
updatePackageVersion( releaseVersion, undefined, next );
}

async function buildRelease( next ) {
Expand Down Expand Up @@ -211,9 +210,12 @@ async function publishToNPM( next ) {

function setNextVersion( next ) {
updateSourceVersion( nextVersion );
updatePackageVersion( nextVersion, "main" );
git( [ "commit", "-a", "--no-verify", "-m", "Updating the source version to " + nextVersion ],
next );
updatePackageVersion( nextVersion, "main", function() {
git(
[ "commit", "-a", "--no-verify",
"-m", "Updating the source version to " + nextVersion ],
next );
} );
}

function pushToRemote( next ) {
Expand Down Expand Up @@ -244,12 +246,22 @@ function steps() {
} )();
}

function updatePackageVersion( ver, blobVer ) {
function updatePackageVersion( ver, blobVer, next ) {
status( "Updating " + packageFile + " version to " + ver );
blobVer = blobVer || ver;
pkg.version = ver;
pkg.author.url = setBlobVersion( pkg.author.url, blobVer );
writeJsonSync( packageFile, pkg );
child.execFile( "npm", [
"version",
ver,
"--no-git-tag-version"
], function( error, stdout ) {
if ( error ) {
throw error;
}
console.log( stdout );
next();
} );
}

function updateSourceVersion( ver ) {
Expand Down
Loading