Add explicit time limits for aslint, htmlcs, nuVal, and qualWeb#2
Open
wittjeff wants to merge 1 commit intojrpool:mainfrom
Open
Add explicit time limits for aslint, htmlcs, nuVal, and qualWeb#2wittjeff wants to merge 1 commit intojrpool:mainfrom
wittjeff wants to merge 1 commit intojrpool:mainfrom
Conversation
These tools currently default to a 15-second timeout, which is insufficient for complex pages. This change adds explicit time limits: - aslint: 45 seconds (runs many rules, needs time for complex DOMs) - htmlcs: 30 seconds (similar complexity to ibm) - nuVal: 30 seconds (makes external HTTP validation calls) - qualWeb: 45 seconds (comprehensive ruleset) This was discovered when scanning https://pope.tech/, where aslint consistently timed out at 15 seconds while other tools completed successfully. The TIMEOUT_MULTIPLIER environment variable still applies to these values for further customization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Problem
When scanning complex pages (e.g., https://pope.tech/), aslint consistently times out at 15 seconds while other tools with explicit time limits complete successfully. This results in 0 aslint instances being collected and an error message:
Backwards Compatibility
TIMEOUT_MULTIPLIERenvironment variable still applies to these valuesTIMEOUT_MULTIPLIER=0.33to restore similar behaviorTesting
Tested against https://pope.tech/ - aslint now completes successfully and returns results.
🤖 Generated with Claude Code