Change bundle path and fix relative URL's

[rehandalal]

Feel free to say: "THESE ARE USELESS CHANGES AND NOBODY NEEDS THEM!".

This does a couple of things:

• CSS bundles will now be in MEDIA_PATH/bundled/css MEDIA_PATH/BUNDLES_DIR/css
• JS bundles will now be in MEDIA_PATH/bundled/js MEDIA_PATH/BUNDLES_DIR/js
• Relative URL's in CSS will now be fixed to point to the correct URL when bundled. (This was a problem on SUMO and recently on Input)

r?

[rehandalal]

I should also probably point out the reason for bundling to the bundled folder.

I happened to have a bundle called jquery and sadly one of the files in the bundle was jquery-min.js which (you guessed it) got replaced with the bundle file.

Now admittedly, this is a silly edge case that would normally not be an issue, and is pretty easy to get around. But I generally like the idea of tossing bundled files in another folder because it also keeps file clutter down in my js/css folders.

[mythmon]

This should be a raw string, like this

css_parsed = re.sub(r'url\(([^)]*?)\)', parse, css_content)

Otherwise, python and re get confused about the back slashes.

[willkg]

If someone updates to this, will they be hosed? Are there things they need to do to update to this version?

[cvan]

is this not in get_media_root()?

[cvan]

if I decide to not set settings.BUNDLES_DIR can we not do the bundled/ stuff?

[rehandalal]

sure i could default that to .

[rehandalal]

@willkg with the new change to the default value of BUNDLES_DIR there should be no compatibility issues.

[rehandalal]

Test added ^

[rehandalal]

And now tests pass ^

If this is all good I'll squash and push

[jsocol]

@cvan any outstanding comments here? @rehandalal Still want to get this merged in?

[davidbgk]

I can't find where you use that package in the diff.

[jsocol]

It's unrelated but missing. There's a test in #63 that demonstrates the issue. Any new tests that hit that area of code will trip over it.

[davidbgk]

I can't understand why there is the /bundled/ path still hard-coded in some places given that there is a setting for that path.

[davidbgk]

Shouldn't that one be wrapped in url() too?