feat(transloco): 🎸 allow to omit available languages#689
Open
json-derulo wants to merge 1 commit intojsverse:masterfrom
Open
feat(transloco): 🎸 allow to omit available languages#689json-derulo wants to merge 1 commit intojsverse:masterfrom
json-derulo wants to merge 1 commit intojsverse:masterfrom
Conversation
|
|
Currently the available languages need to be set, otherwise the translated values won't be returned. With this change, the translation will also work when omitting the availableLangs config, or setting it to null. ✅ Closes: jsverse#653
json-derulo
force-pushed
the
feature/skip-available-langs
branch
from
b65fce9 to
a523726
Compare
Collaborator
|
Thanks for the PR! |
|
I actually like this. The less configuration, the better imo. |
shaharkazaz
force-pushed
the
master
branch
5 times, most recently
from
c068fa2 to
d2ade9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the available languages need to be set, otherwise the translated values won't be returned. With this change the translation will also work when omitting the availableLangs config, or setting it to null.
✅ Closes: #653
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently it is not allow to omit
availableLangsby typings. When setting it to empty array, translation will never work, because there is a check whether the current language is available. There is no way to skip this check.Issue Number: #653
What is the new behavior?
The check whether the current language is in the list of available languages can be skipped by omitting
availableLangsin the config or setting it tonull. This allows translation without the need of maintainingavailableLangs.Does this PR introduce a breaking change?
Other information