Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My original issue what that I was seeing some BGP session close because of hold-timer expired on the remote end.
This was due to the fact that I was consuming the updates rather slowly, and the combine select for received/send was getting somewhat stuck on receiving and could not send the keepalive in time.
Here I propose adding a dedicated goroutine to send the keepalive.
I think this is OK, because even if we consume the updates slowly, it shouldn't prevent us from maintaining the BGP session, the sender can still detect we are falling behind using the TCP ACKs.
There may be better implementation that what I propose here.