Provide pre-built wheels for PyTorch 2.13.0#1357
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for PyTorch 2.13.0, updates the C++ standard to C++20 for PyTorch >= 2.13, refactors the GitHub Actions build scripts to use a pre-installed Python directory, and templates the iterator addition operators in ragged operations. Feedback on these changes suggests removing the unreleased Python 3.15 from the build matrix to prevent CI failures and subsequent list removal errors, as well as simplifying a redundant condition in the PyTorch version check within setup.py.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ), | ||
| }, | ||
| "2.13.0": { | ||
| "python-version": ["3.10", "3.11", "3.12", "3.13", "3.14", "3.15"], |
There was a problem hiding this comment.
Python 3.15 is not yet released, and there are no official stable releases, docker images, or PyTorch wheels available for it. Including "3.15" in the build matrix will cause the CI workflow to fail when attempting to set up the environment or install PyTorch for Python 3.15.
Please remove "3.15" from the list of supported Python versions.
| "python-version": ["3.10", "3.11", "3.12", "3.13", "3.14", "3.15"], | |
| "python-version": ["3.10", "3.11", "3.12", "3.13", "3.14"], |
| if "2.13.0" in matrix: | ||
| matrix["2.13.0"]["python-version"].remove("3.15") |
There was a problem hiding this comment.
Since "3.15" should be removed from the supported Python versions for "2.13.0" (as it is not yet released), this block is no longer needed and would actually cause a ValueError: list.remove(x): x not in list if "3.15" is not present in the list.
Please remove this block.
| if major > 2 or (major == 2 and minor >= 1): | ||
| if major > 2 or (major == 2 and minor >= 13): | ||
| extra_cmake_args += f" -DCMAKE_CXX_STANDARD=20 " | ||
| elif major > 2 or (major == 2 and minor >= 1): |
There was a problem hiding this comment.
The condition major > 2 in the elif statement is redundant because any case where major > 2 is true will already be handled by the preceding if statement on line 156.
You can simplify this to only check for major == 2 and minor >= 1.
| elif major > 2 or (major == 2 and minor >= 1): | |
| elif major == 2 and minor >= 1: |
1 participant
No description provided.