Prevent any scaling operations from happening if trackedTask is running#903
Closed
burmanm wants to merge 3 commits intok8ssandra:masterfrom
Closed
Prevent any scaling operations from happening if trackedTask is running#903burmanm wants to merge 3 commits intok8ssandra:masterfrom
burmanm wants to merge 3 commits intok8ssandra:masterfrom
Conversation
e4df54a to
a26798a
Compare
a26798a to
16b5298
Compare
burmanm
commented
Mar 24, 2026
| return recResult.Output() | ||
| } | ||
|
|
||
| if recResult := rc.CheckCleanupAfterScaling(); recResult.Completed() { |
Contributor
Author
There was a problem hiding this comment.
This position won't work. It can't reliably prevent what we wanted to prevent, but it also shouldn't spawn the cleanup process here, since right now we would spawn it too early.
What we need is a webhook change preventing a change to scale down if ScalingUp is True in CassandraDatacenter.
Contributor
Author
|
This is replaced by the other PR adding webhook validations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds additional blocks for operations that try to scale the cluster if a tracked task is running and it is expected to waited for.
Which issue(s) this PR fixes:
Fixes #902
Checklist