fix: Use local Ollama as default in GitHub Issue Agent demo (manual)#252
Conversation
Update GitHub issue agent YAML to use local Ollama by default to match behaviour in 'agent-examples' repo. Preserve cluster Ollama URL as a commented alternative. Signed-off-by: Daniels Nagornuks <dnagornu@redhat.com>
Add a note to the 'Verify Ollama is running' step explaining how to configure environment variables to connect to an in-cluster Ollama instance. Signed-off-by: Daniels Nagornuks <dnagornu@redhat.com>
rh-dnagornuks
force-pushed
the
fix/demo-agent-ollama-local-env
branch
from
65a8941 to
6422850
Compare
rubambiza
left a comment
rubambiza
left a comment
There was a problem hiding this comment.
Clean, well-scoped fix. The OLLAMA_API_BASE addition is needed for litellm (crewai >=1.10), and aligning the default to local Ollama matches agent-examples. Comments showing both URL options are a nice touch. LGTM.
mrsabath
left a comment
mrsabath
left a comment
There was a problem hiding this comment.
Review Summary
Clean, well-scoped fix that aligns the manual demo defaults with the agent-examples repo. The OLLAMA_API_BASE addition is correct for litellm compatibility (crewai >=1.10). Comments in the YAML and the documentation note make the configuration options clear for users.
Areas reviewed: YAML, Docs, Security, Commit conventions
Commits: 2 commits, all signed-off ✓
CI status: all passing ✓
No issues found. LGTM.
| - name: TASK_MODEL_ID | ||
| value: "ollama/ibm/granite4:latest" | ||
| # Ollama API base URL. Required by litellm (used by crewai >=1.10). | ||
| # For Docker Desktop / Kind: http://host.docker.internal:11434 |
There was a problem hiding this comment.
👍 Nice touch adding both URL options as comments — makes it easy for users to switch between local and in-cluster Ollama.
4 participants
Summary
OLLAMA_API_BASEandLLM_API_BASEin AuthBridge/demos/github-issue/k8s/git-issue-agent-deployment.yaml tohttp://host.docker.internal:11434AuthBridge/demos/github-issue/k8s/git-issue-agent-deployment.yamlAuthBridge/demos/github-issue/demo-manual.mdto inform of the default instance type and provide method to switch to use cluster OllamaContext
Currently, the manual demo for the GitHub Issue Agent defaults to a cluster-based Ollama instance, which differs from the environment variables used in the UI demo: https://github.com/kagenti/agent-examples/blob/main/a2a/git_issue_agent/.env.ollama, and to what is stated within the current version of the deployment YAML: https://github.com/kagenti/kagenti-extensions/blob/main/AuthBridge/demos/github-issue/k8s/git-issue-agent-deployment.yaml
The user is also unaware if or how they need to change the environment variables to use the correct instance of Ollama. This change sets the default instance in the manual demo to the local Ollama instance and adds instructions for switching to a cluster-based Ollama instance if desired.
Tests
kubectl set env