chore(deps): C-339 dependabot consolidation — supersedes #310–#314 (1 taken, 1 corrected, 3 held)#315
Conversation
One reviewable PR replacing five dependabot PRs, with per-dependency judgment instead of blind merges: TAKEN: - @vercel/node 5.8.16 -> 5.8.17 (patch, in-range; supersedes #310) - @types/node aligned to ^20 in atlas-sentinel, sentinels/atlas, sentinels/uriel (was ^18; repo runtime is Node 20). Lockfile now dedupes to a single 20.x at root. Supersedes the *intent* of #312, which wanted 18 -> 25 — types must track the runtime, not latest. HELD (dependabot ignore rules added, following the #308 ESLint precedent): - tailwindcss 4.x (#314): config-system rewrite; 8 apps pin ^3.4.x - http-proxy-middleware 3+/4 (#313): createProxyMiddleware API rewrite; apps/api-gateway uses the v2 API - @nomicfoundation/hardhat-chai-matchers 3 (#311): requires hardhat 3; gic-registry-contracts pins hardhat 2.22.5 — incompatible as proposed - @types/node >=21 (#312): runtime is Node 20 Dependabot auto-closes the superseded PRs once these ignore rules and bumps land on main. https://claude.ai/code/session_014WMkjWLnt4ezGEHujmukLk
|
✅ Drift Compliance: All test vectors passed GI threshold validation |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f1fc9b101
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # @types/node must track the runtime (Node 20 repo-wide), not latest. | ||
| # Declarations aligned to ^20 in C-339; ignore 21+ until runtime moves. | ||
| - dependency-name: "@types/node" | ||
| versions: [">=21"] |
There was a problem hiding this comment.
Keep Node 22 type patch updates unblocked
This versions: [">=21"] ignore is global for every npm workspace, so it also suppresses Dependabot updates for workspaces that already declare Node 22 types. For example, packages/tokenomics-engine and sentinels/aurea both require @types/node ^22.x and the lockfile contains nested @types/node 22.19.21 entries, so future 22.x patch/minor fixes for those workspaces will be ignored along with the unwanted 20→21+ bumps. Use an update-type-based major ignore instead so existing Node 22 consumers can still receive 22.x maintenance updates.
Useful? React with 👍 / 👎.
versions: [">=21"] was global and would have suppressed 22.x maintenance for workspaces that legitimately declare @types/node ^22. An update-types major-only ignore blocks the #312 failure mode (cross-major jumps) while letting in-range patches flow. https://claude.ai/code/session_014WMkjWLnt4ezGEHujmukLk
|
Codex P2 fixed in On the failing checks — this is the C-339 gate (merged in #299) working as designed, not a defect of this PR:
All 24 substantive checks pass, including type-checks over the three packages whose Generated by Claude Code |
|
✅ Drift Compliance: All test vectors passed GI threshold validation |
EPICON Intent Block
package-lock.json, three workspacepackage.jsonfiles,.github/dependabot.ymlignore rules. No workflow, canon, or attested content touched.Safety verdict per PR
@vercel/node5.8.16→5.8.17^5.5.15)@types/node18→25^18.0.0→^20.0.0inpackages/atlas-sentinel,sentinels/atlas,sentinels/uriel; lockfile dedupes to one 20.x. Ignore rule for@types/node >=21hardhat-chai-matchers2→3gic-registry-contractspinshardhat 2.22.5http-proxy-middleware2→4createProxyMiddlewareAPI thatapps/api-gatewayusestailwindcss3→4^3.4.xwithtailwind.config.jsThe ignore rules follow the repo's own precedent (#308, ESLint held at 8.x), each with a comment stating the unblock condition so they're revisitable, not permanent.
Lockfile diff verification
Verified the lock diff contains only:
@vercel/node5.8.16→5.8.17, removal of nested@types/node18.19.130 copies (dedupe to root 20.19.43), in-range nested 22.19.1→22.19.21 refreshes, and theundici-typestransitive. No major versions moved.After merge
Dependabot auto-closes #310–#314 on its next run: #310/#312 because the dependencies moved, #311/#313/#314 because of the ignore rules. No manual closing needed.
Residual risk: the three packages whose types moved 18→20 are type-checked in CI, not locally (worktree had no
node_modules) — if CI's type-check flags anything, I'll fix on this branch.https://claude.ai/code/session_014WMkjWLnt4ezGEHujmukLk
Generated by Claude Code