Skip to content

fix: do not remove two spaces#11

Merged
kalbasit merged 1 commit intomainfrom
fixraoistenarsotien
Mar 21, 2026
Merged

fix: do not remove two spaces#11
kalbasit merged 1 commit intomainfrom
fixraoistenarsotien

Conversation

@kalbasit
Copy link
Owner

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a minor formatting inconsistency in the generated Go code. It specifically targets the wrapperTemplate to eliminate an unnecessary blank line that appeared when //go:build !js tags were included for PostgreSQL database engine builds, resulting in cleaner and more precise code generation.

Highlights

  • Template Formatting: Removed an extraneous blank line within the wrapperTemplate's conditional block for PostgreSQL-specific build tags.
  • Whitespace Control: Adjusted the Go template end directive to ensure correct whitespace handling in the generated code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kalbasit kalbasit merged commit 3c9b4b2 into main Mar 21, 2026
3 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a whitespace formatting issue in a Go template. The proposed change is an improvement, but a further refinement is possible to make the template produce perfectly formatted code without relying on post-processing tools like gofumpt. I've added a comment with a suggestion for a more robust solution that handles all cases correctly.

Comment on lines 57 to +59
{{if .Engine.IsPostgres}}
//go:build !js

{{- end -}}
{{- end}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While your change is an improvement over the original code, it still results in output that is missing a blank line in some cases, relying on gofumpt to fix the formatting. A slightly different approach can produce correctly formatted output directly from the template for both cases (when the if is true or false). This improves the template's clarity and robustness.

Consider this alternative structure:

const wrapperTemplate = `// Code generated by sqlc-multi-db. DO NOT EDIT.
{{if .Engine.IsPostgres}}
//go:build !js

{{end -}}
package {{.PackageName}}
...
`

This would correctly handle newlines for both branches of the if statement, producing well-formatted code directly.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.83%. Comparing base (1382536) to head (1674c62).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   28.83%   28.83%           
=======================================
  Files           6        6           
  Lines         697      697           
=======================================
  Hits          201      201           
  Misses        485      485           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants