Fix mf2util for modern Python#23
Open
Zegnat wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to use mf2util in the latest Python 3.14 and got my logged overvlown by SyntaxWarning.
In this branch I setup a way to locally test a matrix of Python versions using tox and multipython. This was slightly different from the current Travis setup, as multipython does not include Python 3.4. This then turned up a problem with the tests loading JSON files: Travis forces their system to use UTF-8 by default but this is not the case everywhere. So I had to patch the tests to always read the JSON files as Unicode.
With tests configured locally I have added more versions. This turned up a DeprecationWarning at Python 3.7. After fixing that, all the other versions of Python ran without issues. For Python 3.8 and up tox will use uv to install Python.
Note that the final commit changes the version number to my own (
+zegnat.1). If this is merged, either cherry-pick that commit away or follow it up with a new commit updating the version.