fix: deterministic SHACL output + workerd-friendly createNamespace imports#174
Merged
karelklima merged 3 commits intoMay 20, 2026
Conversation
Contributor
Author
|
Heads up on the failing |
Owner
|
@renanpontez Thanks for the fix, looks good to me. I released a new version of LDkit (2.7.1) that includes the fix. You are correct regarding the CI issue - it it indeed Deno related and should be resolved with the next Deno release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups to #172 (SHACL → schema CLI converters):
Deterministic property order.
a.
n3Store quad iteration order isn't guaranteed stable across parses, so re-runningshacl-to-schemaagainst the same input could produce noisy diffs in generated files.b. Properties are now sorted alphabetically before emit. Adds a regression test covering this.
Workerd-friendly
createNamespaceimport path.a. The generated code (and a couple of internal scripts) imported
createNamespacefrom the rootldkitentrypoint. That entrypoint transitively pulls in modules that don't load in Cloudflare Workers / workerd.b. Switched all 4 call sites (
scripts/extract_namespace.ts,scripts/schema_to_script.ts,scripts/schema_to_package.ts, plus the generator) to import fromldkit/namespaces, which is the narrow, side-effect-free entrypoint.c. Tests updated to match.
Both issues were surfaced while consuming the converter in a workerd-deployed project after #172 landed.
Test plan
deno test tests/scripts/shacl_to_schema.test.ts tests/scripts/schema_to_script.test.ts— 47 passed, 0 failed