Sanitize chat newlines before storing in the content map#16
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
TransmitInternal inoculates chat content against internal newlines so they cannot break the name=value body format. The inoculation loop replaces \n with \t, but it ran after the raw message was already copied into the content map. The map entry (used to assemble the transmitted body) retained the original newlines, so a chat message like "Hello\nmsg.sync.passPhrase=Injected" became two protocol fields at the receiver, and the map's last-write-wins semantics let the injected field override the legitimate value. Move the \n-to-\t substitution before the assignment to content[BSP_MSG_CHAT] so the sanitized value is what gets stored and transmitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransmitInternal inoculates chat content against internal newlines so
they cannot break the name=value body format. The inoculation loop
replaces \n with \t, but it ran after the raw message was already
copied into the content map, so the map entry retained the original
newlines. A chat message like "Hello\nmsg.sync.passPhrase=Injected"
becomes two protocol fields at the receiver, and the map's
last-write-wins semantics let the injected field override the
legitimate value.
This moves the \n-to-\t substitution before the assignment to
content[BSP_MSG_CHAT] so the sanitized value is what gets stored and
transmitted.