Skip to content

ISSUE #34 - improve port resolution#36

Open
jsnfwlr wants to merge 1 commit intokarol-broda:masterfrom
jsnfwlr:issue-34
Open

ISSUE #34 - improve port resolution#36
jsnfwlr wants to merge 1 commit intokarol-broda:masterfrom
jsnfwlr:issue-34

Conversation

@jsnfwlr
Copy link
Copy Markdown

@jsnfwlr jsnfwlr commented Jan 15, 2026

Description

  • standardize tcp4/tcp6 as tcp, and udp4/udp6 as udp before performing resolution
  • use github.com/thediveo/netdb for quick and easy resolution that can be expanded with definition file if needed in the future

Related Issues

#34

Type of Change

  • bug fix
  • new feature
  • breaking change
  • documentation
  • refactoring
  • other:

AI Disclosure

  • ai: none — no ai assistance used
  • ai: assisted — ai helped with portions (describe below)
  • ai: generated — significant portions were ai-generated (describe below)

Checklist

  • i have tested these changes locally
  • i have run make test and all tests pass
  • i have run make lint and fixed any issues
  • i have updated documentation if needed
  • my code follows the existing style of the project

Screenshots / Terminal Output

image

- standardize tcp4/tcp6 as tcp, and udp4/udp6 as udp before performing resolution
- use github.com/thediveo/netdb for quick and easy resolution that can be expanded with definition file if needed in the future
@jsnfwlr
Copy link
Copy Markdown
Author

jsnfwlr commented Jan 27, 2026

@karol-broda can I please get eyes on this?

@karol-broda
Copy link
Copy Markdown
Owner

hey @jsnfwlr , sorry for the late reply on this. the tcp6/udp6 fix is spot on.
i'm gonna pass on the netdb dependency for now, trying to keep external deps minimal. will probably just parse /etc/services directly instead. might revisit the library idea later
appreciate the effort either way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants