Skip to content

Update package metadata reading method in GitHub Actions workflow #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasuken merged 1 commit into from
Sep 8, 2025
Merged

Update package metadata reading method in GitHub Actions workflow #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/publish-extension.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ jobs:
- name: Read package metadata
id: get_meta
run: |
echo "version=$(node -p \"require('./package.json').version\")" >> "$GITHUB_OUTPUT"
echo "name=$(node -p \"require('./package.json').name\")" >> "$GITHUB_OUTPUT"
echo "vsix=$(node -p \"const p=require('./package.json'); p.name + '-' + p.version + '.vsix'\")" >> "$GITHUB_OUTPUT"
node -e "const fs=require('fs'); const p=require('./package.json'); const out=process.env.GITHUB_OUTPUT; fs.appendFileSync(out, `version=${p.version}\n`); fs.appendFileSync(out, `name=${p.name}\n`); fs.appendFileSync(out, `vsix=${p.name}-${p.version}.vsix\n`);"
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This single-line command is difficult to read and maintain. Consider breaking it into multiple lines or using a here document for better readability.

Suggested change
node -e "const fs=require('fs'); const p=require('./package.json'); const out=process.env.GITHUB_OUTPUT; fs.appendFileSync(out, `version=${p.version}\n`); fs.appendFileSync(out, `name=${p.name}\n`); fs.appendFileSync(out, `vsix=${p.name}-${p.version}.vsix\n`);"
node <<'EOF'
const fs = require('fs');
const p = require('./package.json');
const out = process.env.GITHUB_OUTPUT;
fs.appendFileSync(out, `version=${p.version}\n`);
fs.appendFileSync(out, `name=${p.name}\n`);
fs.appendFileSync(out, `vsix=${p.name}-${p.version}.vsix\n`);
EOF

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing input validation for package.json properties. If p.version or p.name contain special characters or newlines, they could corrupt the GITHUB_OUTPUT format.

Suggested change
node -e "const fs=require('fs'); const p=require('./package.json'); const out=process.env.GITHUB_OUTPUT; fs.appendFileSync(out, `version=${p.version}\n`); fs.appendFileSync(out, `name=${p.name}\n`); fs.appendFileSync(out, `vsix=${p.name}-${p.version}.vsix\n`);"
node -e "const fs=require('fs'); const p=require('./package.json'); const out=process.env.GITHUB_OUTPUT; const esc=s=>s.replace(/%/g,'%25').replace(/\\n/g,'%0A').replace(/\\r/g,'%0D'); fs.appendFileSync(out, `version=${esc(p.version)}\n`); fs.appendFileSync(out, `name=${esc(p.name)}\n`); fs.appendFileSync(out, `vsix=${esc(p.name)}-${esc(p.version)}.vsix\n`);"

Copilot uses AI. Check for mistakes.

- name: Upload VSIX artifact (optional)
uses: actions/upload-artifact@v4
Expand Down
Loading